oxidecomputer / oxidecomputer/omicron
Consider changing database certificate storage type
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
Certificates are currently accepted and returned as PEM encoded strings, but in the database we store them as bytes. If we are always going to used a string based format, we may want to change our database representation. Though if we intend to accept other formats and serialize an enum of types to a binary form we may not want to change this.
Reference: https://github.com/oxidecomputer/omicron/pull/5078
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with schema/crdb/dbinit.sql lines 397-401 and read the referenced pull request #5078. Determine whether certificates will remain PEM-only or need multiple formats; done means resolving that design and updating the database representation consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- databases
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100