oxidecomputer / oxidecomputer/omicron
Rotated logs should not use timestamps as a marker
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
When the rack is coming up, it starts in 1986. This makes timestamps as a suffix for rotated logs meaningless, and it's very difficult to find information. Rotated logs should have a suffix/label that increases relative to the number of resident rotated logs with the same file name, or some other unit of measure that allows us to sort things out after the fact.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named in the issue. Start by locating the log-rotation entry point and checking how suffixes are generated when the rack starts in 1986; done means rotated logs with the same file name use an orderable non-timestamp marker, with the behavior covered by a test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- observability
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100