oxidecomputer / oxidecomputer/omicron
sled expungement should clean up sled underlay allocations
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
Right now, if you add a sled and then remove it, I think we'll wind up leaking the sled_underlay_subnet_allocation row for it. There are only about (255 - 33) = 222 possible records in this table per rack, so I expect this means that we'd be unable to add more than 222 sleds to a rack (no matter how many expungements have been done).
We probably don't want to remove (or invalidate) these records until the sled actually becomes decommissioned. Otherwise, we might pick the same subnet for a newly added sled and there may be components on two sleds using the same subnet. Separately, we might want to avoid reusing recently-used subnets anyway.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Trace the sled expungement path and its handling of sled_underlay_subnet_allocation; confirm when a sled becomes decommissioned and how allocation rows are retained or released. Done means expungement no longer leaves unreclaimable rows while avoiding subnet reuse before decommissioning, with coverage for both cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend, database
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100