oxidecomputer / oxidecomputer/omicron
Flake in `test_simulated_api_matches_real`
Open
Nobody has claimed this yet.
Test Flake
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
https://github.com/oxidecomputer/omicron/pull/5481/checks?check_run_id=23674484033
5622 2024-04-10T18:39:02.097Z FAIL [ 23.320s] omicron-sled-agent sim::http_entrypoints_pantry::tests::test_simulated_api_matches_real
5623 2024-04-10T18:39:02.097Z
5624 2024-04-10T18:39:02.097Z --- STDOUT: omicron-sled-agent sim::http_entrypoints_pantry::tests::test_simulated_api_matches_real ---
5625 2024-04-10T18:39:02.097Z
5626 2024-04-10T18:39:02.098Z running 1 test
5627 2024-04-10T18:39:02.098Z test sim::http_entrypoints_pantry::tests::test_simulated_api_matches_real ... FAILED
5628 2024-04-10T18:39:02.098Z
5629 2024-04-10T18:39:02.098Z failures:
5630 2024-04-10T18:39:02.098Z
5631 2024-04-10T18:39:02.098Z failures:
5632 2024-04-10T18:39:02.098Z sim::http_entrypoints_pantry::tests::test_simulated_api_matches_real
5633 2024-04-10T18:39:02.098Z
5634 2024-04-10T18:39:02.098Z test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 63 filtered out; finished in 23.31s
5635 2024-04-10T18:39:02.098Z
5636 2024-04-10T18:39:02.098Z
5637 2024-04-10T18:39:02.098Z --- STDERR: omicron-sled-agent sim::http_entrypoints_pantry::tests::test_simulated_api_matches_real ---
5638 2024-04-10T18:39:02.098Z thread 'sim::http_entrypoints_pantry::tests::test_simulated_api_matches_real' panicked at sled-agent/src/sim/http_entrypoints_pantry.rs:322:41:
5639 2024-04-10T18:39:02.098Z called `Result::unwrap()` on an `Err` value: Error("trailing characters", line: 1, column: 4)
Looks like this crucible-pantry.json file might be not reliably getting downloaded, oddly?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with sled-agent/src/sim/http_entrypoints_pantry.rs, especially test_simulated_api_matches_real and the failure at line 322. Reproduce the test using the linked check and Buildomat logs, then determine why crucible-pantry.json can produce the reported JSON trailing-characters error; done means the test no longer flakes or fails during that download and parse path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100