oxidecomputer / oxidecomputer/omicron
vpc_resolve_to_sleds instance lookup code doesn't have test coverage
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
I was in the VPC code and was trying to figure out how the query on instance_network_interface would interact with sled expungement. I couldn't find any tests, for this chunk of code, as #5427 demonstrates.
It would be great to have some tests for this, so we have its interaction with sled expungement written down.
cc @jgallagher, @luqmana, @plotnick who have touched this code.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the VPC code entry point named vpc_resolve_to_sleds and inspect how its instance_network_interface query interacts with sled expungement. Read the example in #5427 and find the existing VPC test layout before adding coverage. Done means tests document the expected behavior for sled expungement interactions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend, testing-qa
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100