oxidecomputer / oxidecomputer/omicron

another test flake after failure to sync NTP in helios-deploy

Open
#5,349 19 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Test Flake
Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

This looks just like #4307. Here's the test failure:

https://github.com/oxidecomputer/omicron/pull/5345/checks?check_run_id=23226775903
https://buildomat.eng.oxide.computer/wg/0/details/01HT43K6DFF7KS1M2PN7KQFTDG/fW9lP6upEQI9pj7K7lEZocNM6gn0czizN5qB8WHkeoWga25U/01HT43Q01QEF77V3S3V6MNGSVY

Similarly, sled agent reports "Time is not yet synchronized" from 05:53:22.154Z til 05:58:17.467Z. We gave up on the test at 05:58:31.781Z.

The PR change looks pretty unrelated to any of this.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading issue #4307 and the linked failure details from PR #5345, then review the Buildomat run for the helios-deploy test. Reproduce or inspect the failure around the sled agent's unsynchronized clock period; done means the test no longer flakes when NTP synchronization is delayed.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
distributed-systems, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.