oxidecomputer / oxidecomputer/omicron
Replace sled's time_deleted with time_decommissioned
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
Followup from https://github.com/oxidecomputer/omicron/pull/5032.
A sled's lifecycle is a bit more complicated than time_deleted, so we want to replace it with a time_decommissioned.
According to the spec (RFD 457), time_decommissioned will be the same as time_updated since we no longer permit updates to a sled after it is decommissioned. However, there may be bugs in the implementation and a separate column is a reasonable way to guard against that.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing pull request 5032 and RFD 457 to understand the sled lifecycle and the intended meaning of time_decommissioned. Locate the sled schema and related uses of time_deleted, then verify that the replacement is consistent with the decommissioning rules and no longer permits post-decommission updates.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend, databases
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100