oxidecomputer / oxidecomputer/omicron

Add limit to how many SSH keys a user can have in their account

Open
#4,918 0 comments 0 reactions 1 assignee View on GitHub

@david-crespo is already working on this.

Since Feb 26, 2024.

api
Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

As per #4764, a user can transfer up to 100 SSH keys to an instance but technically has no limit on how many keys can be added to their account. This means that there exists a scenario in which a user has 100+ keys and expects all of those keys to get transmitted to the instance but only the first 100 get transmitted. The current behavior is to silently succeed whereas we eventually either want to have the same limit of keys per instance / keys per account or have some other means of ensuring this scenario doesn't happen. It may be that the work in #4919 removes the particular edge case here whereby just setting some top level limit would be sufficient.

See this comment for more details: https://github.com/oxidecomputer/omicron/pull/4764#discussion_r1467884930

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.