oxidecomputer / oxidecomputer/omicron
Add a better error for when a user tries to provision past their quota
Open
@david-crespo is already working on this.
Since Feb 26, 2024.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
#4605 introduced quotas and uses the InsufficientCapacity error added by @sunshowers in #4573. InsufficientCapacity generates a 5xx error but I believe we should both have a distinct error type and a 400 error code for when provisioning fails due to quotas. As mentioned in #4573, AWS has good documentation on their api errors. They have InsufficientCapacity as a 5xx server error related to their servers not having the resources to handle a request and 4xx client errors like VcpuLimitExceeded for when users try to over provision their allotted resources.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.