oxidecomputer / oxidecomputer/omicron
INTERNAL_SILO missing "virtual_provisioning_collection_create"
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
While debugging with @zephraph , I noticed that load_builtin_silos doesn't actually create a "virtual_provisioning_collection" object for the INTERNAL_SILO. I don't think this is an immediately is a concern -- we aren't really provisioning CPUs/Memory/Disks here, since this silo appears to be for IPs only -- but this "virtual_provisioning_collection" table needs to exist if we'd ever allocate resources within this silo.
FYI @david-crespo ? I dunno if this overlaps with your IP pool re-arranging
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading load_builtin_silos and locating how the virtual_provisioning_collection table or object is created. Confirm whether INTERNAL_SILO is expected to include this collection, including the possible overlap with the IP pool rearrangement mentioned in the issue. Done means the intended INTERNAL_SILO provisioning state is created and covered by the relevant existing checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend, databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100