oxidecomputer / oxidecomputer/omicron
RSS erroneously retries non-retryable failures
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
While working on #4466, I noticed that initialize_zones_on_sled() retries on any kind of error:
https://github.com/oxidecomputer/omicron/blob/3555b5d2f4827269a61608ad012f258b74d676fb/sled-agent/src/rack_setup/service.rs#L292
It should not retry, for example, a 400-level error or a 500. We probably need to generalize something like this:
https://github.com/oxidecomputer/omicron/blob/3555b5d2f4827269a61608ad012f258b74d676fb/clients/dns-service-client/src/lib.rs#L28
(Originally posted by @jgallagher in https://github.com/oxidecomputer/omicron/pull/4466#discussion_r1409361735)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in sled-agent/src/rack_setup/service.rs at initialize_zones_on_sled(), then compare the retry classification with clients/dns-service-client/src/lib.rs around line 28. Confirm how errors expose their status and define done as retrying only retryable failures, not 400-level errors or 500 responses.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100