oxidecomputer / oxidecomputer/omicron
Use `next_item` CTE helper for sled subnet allocation when adding a sled to an initialized rack
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
Currently, subnet allocation is done manually in omicron_nexus::app::rack::Nexus::add_sled_to_initialized_rack inside rust code, outside CRDB. However, this means that concurrent add sled operations will fail due to reusing allocations. We can avoid this problem via the use of the next_item helper
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in omicron_nexus::app::rack::Nexus::add_sled_to_initialized_rack, where subnet allocation is currently performed in Rust. Read the next_item CTE helper in nexus/db-queries/src/db/queries/next_item.rs and trace how it can be used for this allocation. Done means concurrent add-sled operations no longer reuse subnet allocations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100