oxidecomputer / oxidecomputer/omicron

Failed end-to-end test in CI did not include Propolis logs in output artifacts

Open
#4,490 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug Testing & Analysis
Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

https://buildomat.eng.oxide.computer/wg/0/details/01HEXKACYWF89VM1E9CTJYVV3R/Lpprn4Zt49bMSVdfGonecyoOgVrADSncQ5GrM2n30Tfe2sK4/01HEXKATT657FMT1H9Z7WPQBJB

This end-to-end test run failed waiting for the guest to display its SSH key sigil on its serial console. We'd like to have the Propolis logs in cases like this to see if the host believes the guest did anything untoward. However, the output rules for this job appear to exclude these logs:

BasicConfig {
    output_rules: [
        "%/var/svc/log/oxide-sled-agent:default.log*",
        "%/pool/ext/*/crypt/zone/oxz_*/root/var/svc/log/oxide-*.log*",
        "%/pool/ext/*/crypt/zone/oxz_*/root/var/svc/log/system-illumos-*.log*",
        "%/pool/ext/*/crypt/zone/oxz_ntp_*/root/var/log/chrony/*.log*",
        "!/pool/ext/*/crypt/zone/oxz_propolis-server_*/root/var/svc/log/*.log*",
        "%/pool/ext/*/crypt/debug/global/oxide-sled-agent:default.log.*",
        "%/pool/ext/*/crypt/debug/oxz_*/oxide-*.log.*",
        "%/pool/ext/*/crypt/debug/oxz_*/system-illumos-*.log.*",
        "!/pool/ext/*/crypt/debug/oxz_propolis-server_*/*.log.*",
    ],

Per the Buildomat readme:

To exclude specific files from upload, the ! prefix can be used to signify that "any file that matches this pattern should be ignored, even if it was nominally included by another pattern". Order in the array is not important; a match of any exclusion rule will prevent that file from behing uploaded.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the failed Buildomat run and the BasicConfig output_rules shown in the issue; trace where this job's artifact patterns are defined. Done means failed end-to-end runs upload the relevant Propolis logs while preserving the existing artifact exclusions, and the behavior is verified in CI.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
ci-cd, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.