oxidecomputer / oxidecomputer/omicron

Check BGP announce set address lot

Open
#4,391 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug networking
Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

Creating a BGP announcement requires specifying an address lot for the prefix being advertised. But we are not currently checking the address lot reference.

https://github.com/oxidecomputer/omicron/blob/561f54502ec7dcced9fdd54fc7ab6407343974db/nexus/db-queries/src/db/datastore/bgp.rs#L241-L280

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in nexus/db-queries/src/db/datastore/bgp.rs at lines 241-280 and trace the BGP announcement creation path. Confirm how the address lot reference is represented and validated; the work is done when creating an announcement checks that reference before accepting the advertised prefix.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend, networking
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.