oxidecomputer / oxidecomputer/omicron

improve instance hostname validation

Open
#4,301 0 comments 0 reactions 1 assignee View on GitHub

@iliana is already working on this.

Since Oct 19, 2023.

Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

That was the intent. In RFD 4 names were defined to be compliant with RFC 1035. However, I don't think we ever validated hostname the same way:

https://github.com/oxidecomputer/omicron/blob/463cc1ae256a5e22b9726ae58ea8b651e81e3882/common/src/api/internal/nexus.rs#L38-L40

Originally posted by @davepacheco in https://github.com/oxidecomputer/omicron/pull/4265#discussion_r1364248098

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.