oxidecomputer / oxidecomputer/omicron

dbinit.sql: Consider naming all CONSTRAINT and CHECKs explicitly

Open
#4,256 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

database
Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

If they are given anonymous names, they are position-dependent, and also dependent on the name of the table to which they belong.

By providing explicit names, it should be easier to update these checks, and to re-order the declaration of tables.

see: schema/crdb/README.adoc for more details.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read schema/crdb/README.adoc for the naming details, then inspect dbinit.sql and locate every anonymous CONSTRAINT and CHECK declaration. Rename each explicitly and verify that all declarations are covered without changing their validation behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
sql
Domain
database
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.