oxidecomputer / oxidecomputer/omicron
Use `NameOrId` in `InstanceCreate.external_ips`
Open
Nobody has claimed this yet.
api
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
https://github.com/oxidecomputer/omicron/pull/3985#discussion_r1310619480
I think the main reason it was name only was that the name "default" was significant, and now it isn't.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read nexus/types/src/external_api/params.rs around lines 802-811 and 840-846, then trace the InstanceCreate.external_ips type and the existing NameOrId definition. Update the parameter to use NameOrId and verify that the external API type matches the discussion's intended behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- api
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100