oxidecomputer / oxidecomputer/omicron
Boundary Services MAC address conflicts with Guest Addresses range.
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
The fixed MAC we use to logical represent Boundary Services is currently set to:
https://github.com/oxidecomputer/omicron/blob/eee942f601bbebf00352eb5c5f060e1e80a437e6/illumos-utils/src/opte/mod.rs#L46
But based on the current MAC address allocation scheme it lies in the Guest Addresses range
https://github.com/oxidecomputer/omicron/blob/eee942f601bbebf00352eb5c5f060e1e80a437e6/common/src/api/external/mod.rs#L1870-L1887
In practise I don't think it's really a problem, as the boundary services mac is effectively arbitrary and not used for forwarding or filtering packets, but probably good to update nonetheless.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read the fixed Boundary Services MAC in illumos-utils/src/opte/mod.rs around line 46, then compare it with the Guest Addresses allocation in common/src/api/external/mod.rs around lines 1870-1887. Update the fixed value so it no longer falls within the Guest Addresses range, and verify the allocation definitions remain consistent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100