oxidecomputer / oxidecomputer/omicron
Overly long description → `500 Internal Server Error` on image creation
Open
Nobody has claimed this yet.
bug
nexus
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
There's a 512-character limit for image descriptions, and I was curious whether that was enforced on the client or server, so...
{
"name": "ubuntu-linux",
"description": "I'd just like to interject for a moment. What you're referring to as Linux, is in fact, GNU/Linux, or as I've recently taken to calling it, GNU plus Linux. Linux is not an operating system unto itself, but rather another free component of a fully functioning GNU system made useful by the GNU corelibs, shell utilities and vital system components comprising a full OS as defined by POSIX. Many computer users run a modified version of the GNU system every day, without realizing it. Through a peculiar turn of events, the version of GNU which is widely used today is often called “Linux,” and many of its users are not aware that it is basically the GNU system, developed by the GNU Project. There really is a Linux, and these people are using it, but it is just a part of the system they use.",
"os": "Ubuntu",
"version": "20.24",
"source": {"you_can_boot_anything_as_long_as_its_alpine": { }, "type": "you_can_boot_anything_as_long_as_its_alpine"}
}
$ ./target/debug/oxide image create --json-body lol.json
error
Error Response: status: 500 Internal Server Error; headers: {"content-type": "application/json", "x-request-id": "530f38b5-201b-4bdf-8b0c-2ebe211418b6", "content-length": "124", "date": "Thu, 10 Aug 2023 20:07:44 GMT"}; value: Error { error_code: Some("Internal"), message: "Internal Server Error", request_id: "530f38b5-201b-4bdf-8b0c-2ebe211418b6" }
This works with a shorter description.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the request through the oxide image create command with the provided JSON body, then compare it with a shorter description. Trace the image-creation API handling for descriptions over 512 characters; done means the request returns an appropriate validation response instead of a 500 Internal Server Error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100