oxidecomputer / oxidecomputer/omicron
Reflect instance resource limits in schema
Open
@just-be-dev is already working on this.
Since Aug 7, 2023.
- #3864 by @just-be-dev — closed without merging
api
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
I implemented API level instance resource limits in https://github.com/oxidecomputer/omicron/pull/3574 and then updated them in https://github.com/oxidecomputer/omicron/pull/3819. As I was working on updating console I realized the schema doesn't actually include the limits (thus it's not reflected in the docs or checked with the typescript client's auto generated validators). We should obviously update this so it's easier for clients to validate.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.