oxidecomputer / oxidecomputer/omicron

improve schema check for `DeploymentConfig`

Open
#3,741 0 comments 0 reactions 1 assignee View on GitHub

@ahl is already working on this.

Since Jul 21, 2023.

Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

After talking to @davepacheco, we should explicitly copy the contents out of dropshot::ConfigDropshot into DeploymentConfig and then construct the dropshot::ConfigDropshot(s) from those properties. This will mean that a breaking change in dropshot forces us to consider how to handle new/changed properties.

In addition, we should add a README.md to the schema directory.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.