oxidecomputer / oxidecomputer/omicron

Create Reliable Persistent Workflow for maintaining switch NAT configurations

Open
#3,593 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

networking
Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

https://github.com/oxidecomputer/omicron/blob/973bff16f09d0bf9fca03641053c8ebd88c46b72/nexus/src/app/instance.rs#L269-L270

When the set of boundary switches changes, there is no cleanup / reconciliation logic performed to ensure that the NAT entries are propogated to new boundary switches / removed from former boundary switches, meaning we could end up with stale or missing entries.

Reference:
https://github.com/oxidecomputer/omicron/pull/3262#discussion_r1256436736

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at nexus/src/app/instance.rs around lines 269-270 and read the referenced discussion in pull request #3262. Trace how boundary-switch changes are handled and identify the existing NAT propagation entry points. Done means NAT entries are reconciled when switches are added or removed, preventing stale or missing entries.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend, networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.