oxidecomputer / oxidecomputer/omicron

authn should validate that the user belongs to this endpoint's Silo

Open
#3,529 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

authn security
Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

Nexus runs an external endpoint for each Silo. In a real system, Nexus determines which endpoint is being used based on the HTTP/1.1 "Host" header or HTTP/2 authority pseudo-header. If you come to https://eng.sys.$domain we know you're reaching the "eng" Silo's endpoint. This works for both authenticated and unauthenticated requests. During successful authentication, we will look up a user's session cookie or device authn token and then wind up with an identity that's associated with a particular Silo. There's nothing to verify that these two Silos match. You could totally take your session cookie for an identity in the "eng" Silo and use it at https://finance.sys.$domain. This shouldn't allow you to do anything or see anything that you couldn't access at https://eng.sys.$domain -- it should behave exactly like https://eng.sys.$domain -- but it's confusing and seems like a way we might accidentally introduce vulnerabilities.

This is all pretty straightforward in the case of a real system where people have deployed TLS and delegated external DNS to the rack. We'll need to figure out what to do for development systems, where people usually don't use TLS and don't use DNS -- they access the endpoint by IP address. I'd suggest we have a dev-only configuration knob that just skips this check since it doesn't make sense in this configuration. And again, it shouldn't be load-bearing for security.

(pulled from #849)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points, so begin by locating authentication handling and how the request endpoint's Silo is identified. Done means an authenticated identity cannot be used across Silo endpoints, while development systems without TLS or DNS have an explicit way to skip the check.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
api, authentication
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.