oxidecomputer / oxidecomputer/omicron
log all RSS HTTP requests by default
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
Debugging #3498 I wished we had log messages for the HTTP requests that RSS makes to Sled Agents. I see that all requests made using a sled_agent_client::Client are logged at "debug" level. But our configs only keep "info" level messages (which I think makes sense). I'm not sure how best to proceed. We could make all sled_agent_client::Client messages "info"-level. That would affect other consumers, too. I'm not sure if that's a problem, if we have high-throughput latency-critical paths that hit the Sled Agent. It seems like maybe not?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the RSS HTTP request path to the sled_agent_client::Client calls mentioned in the issue, and inspect how the repository's info-level configuration filters their debug logs. Determine whether RSS requests should be logged by default without changing logging behavior for other Client consumers; done means the intended requests are visible under the default configuration.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- api
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100