oxidecomputer / oxidecomputer/omicron
Reassess authz testing and operation IDs for system and silo metrics
Open
Nobody has claimed this yet.
nexus
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
- Given that the authz tests won't allow us to retest the same endpoint twice (with different query params) we don't have complete coverage of all the authz cases. We should update the tests to treat different query params as a unique URL in terms of test coverage
- I'm still unsure about the operation names for metrics. We want to get those right because it'll impact the SDKs.
Originally posted by @zephraph in https://github.com/oxidecomputer/omicron/pull/3401#pullrequestreview-1505787949
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue does not name specific files, tests, or entry points. Start by locating the authorization coverage tests and the operation-ID definitions for system and silo metrics; review how query parameters are currently handled and how names reach SDKs. Done means coverage distinguishes query parameters and the metric operation names have a settled, reviewed convention.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- api, observability, security
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100