oxidecomputer / oxidecomputer/omicron
v1 session management cleanup
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
- Don't reseed RNG on every token generation
- Put session token size in a constant somewhere (currently hardcoded at generation and DB column string length)
- Make wrapper type for session token (similar to
Name) instead of usingStringdirectly - Put a prefix on the session cookie that lets us tell what version it is?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the session-token generation, session cookie handling, and database schema or model code implicated by the checklist. Review how randomness, token lengths, and session tokens are currently represented before deciding whether the four proposed changes belong together. Done means the agreed cleanup is implemented consistently and covered by the relevant existing tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- authentication, backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100