oxidecomputer / oxidecomputer/omicron

Adjust Sled Agent firewall entrypoint

Open
#3,355 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

api cleanup
Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

Today, SledAgent exposes an API at /vpc/{vpc_id}/firewall/rules that Nexus uses to update the firewall rules on a sled. But we don't actually use that vpc_id path parameter ever.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Trace the SledAgent endpoint for /vpc/{vpc_id}/firewall/rules and the Nexus caller that updates firewall rules. Determine the intended entrypoint without the unused vpc_id parameter; done means the API and its callers consistently use the revised route.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
api
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.