oxidecomputer / oxidecomputer/omicron

test instance unexpectedly went from Stopped to Stopping, preventing it from being deleted

Open
#3,261 1 comment 0 reactions 1 assignee View on GitHub

@gjcolombo is already working on this.

Since May 30, 2023.

Sled Agent
Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

(NOTE: The problem below is probably not the real issue; see the next comment for more analysis. The below is preserved for posterity.)

Relevant code: https://github.com/oxidecomputer/omicron/blob/1bd6420b6124460ab5cc1f552292252c629c84b6/sled-agent/src/instance.rs#L723-L730

Sled agent needs to apply its state transition in this path before asking Propolis to change its state. Otherwise, sled agent can clobber a Propolis state update:

  • sled agent asks Propolis to stop its VM
  • Propolis pushes the VM to Stopping
  • Propolis pushes the VM to Stopped
  • sled agent manually calls transition to move the instance back to Stopping

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.