oxidecomputer / oxidecomputer/omicron
Create types for validating fields used with LLDP
Open
Nobody has claimed this yet.
networking
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
Currently we're using Strings, whose length can exceed the size allowed by LLDP TLVs.
Reference: https://github.com/oxidecomputer/omicron/pull/2645#discussion_r1181752862
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at common/src/api/external/mod.rs lines 2365-2382 and read the linked discussion in pull request 2645. Identify the fields currently represented as String and determine the LLDP TLV size constraints they must enforce. Done means those fields use validation types that prevent values exceeding the allowed LLDP lengths.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- api, networking
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100