oxidecomputer / oxidecomputer/omicron
`idp_entity_id` is redundant in Saml IdP creation payload
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
We could simplify the SAML IdP creation payload a little bit. Today it looks like:
idp_entity_id is available as the entityID attribute on the root EntityDescriptor node from the IdP metadata XML.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in nexus/types/src/external_api/params.rs at the SAML IdP creation payload definition linked in the issue. Trace uses of idp_entity_id and the metadata EntityDescriptor entityID value, then check the surrounding API tests or callers. Done means the redundant field is removed consistently and the payload still represents the IdP entity ID through metadata.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- api
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100