oxidecomputer / oxidecomputer/omicron
Silo/Project image create queries are upserts when they should be inserts
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
As @davepacheco pointed out in #2772 the image/project create queries were formed more as an upsert than an insert. We should fail if the resource already exists rather than updating it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the image and project create query changes in PR #2772 and the linked discussion. Locate the current create-query entry points and their tests, then verify that attempting to create an existing resource fails rather than updating it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend-api-design, databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100