oxidecomputer / oxidecomputer/omicron

Sim sled-agent: Stopped instances lose their disks

Open
#2,803 1 comment 0 reactions 1 assignee View on GitHub

@jmpesp is already working on this.

Since Apr 14, 2023.

development
Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

The sim sled-agent now marks disks as detached when an instance is in the stopped state because of the fix for https://github.com/oxidecomputer/omicron/issues/2675 ( https://github.com/oxidecomputer/omicron/commit/207768ea2bdc644da2c5c7b5f7ababab4a6f4e95). An instance in stopped state should probably still own the disks (although they are not mounted/attached physically). If not, when the instance is started again, it will have no disk.

@smklein, @jmpesp - The change is only confined to the simulated sled-agent. Does it reflect how a real sled would work in the stopped and destroyed instance scenarios? (To be clear, I'm less concerned if this is only a sim sled-agent issue and won't happen to a real sled.)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.