oxidecomputer / oxidecomputer/omicron

wicket-dbg "run" behavior confusing - need better state management

Open
#2,685 0 comments 0 reactions 1 assignee View on GitHub

@andrewjstone is already working on this.

Since Mar 27, 2023.

wicket
Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

This is a bug currently affecting the not yet merged wicket-dbg in https://github.com/oxidecomputer/omicron/pull/2682.

wicket-dbg allows running playback of a recording with the run command. Playback can be resumed with the resume command. The rationale for a separate command was to allow run to be entered again and start from the beginning. However, it appears that run will actually start over, but not all the state is reset leading to anomalous behavior. It also isn't clear that the resume command should even exist. We already have reset for manually going back to the beginning.

Suggested fix is to remove the resume command, ensure that reset actually resets all state to default, and then allow run to resume from the current event when playback is not already running.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.