oxidecomputer / oxidecomputer/omicron
omicron-package deactivate unconditionally deletes `cxgbe0/ll` addresses - it shouldn't
Open
Nobody has claimed this yet.
build
development
networking
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
We should respect the OMICRON_NO_UNINSTALL environment variable, and avoid this deletion like we do for uninstall.
Otherwise, deactivating omicron disconnects the ip addresses we normally use for accessing gimlets remotely in the first place, which can be a little confusing!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the omicron-package deactivate path and compare its handling of OMICRON_NO_UNINSTALL with uninstall. Verify that deactivation with the variable set does not delete the cxgbe0/ll addresses used for remote access.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100