oxidecomputer / oxidecomputer/omicron
Allow deleting of disks from the various importing states
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
From the import blocks to disks PR:
Currently we can only delete a disk from the Detached state: if the user gives up on an import, it's possible to bulk-write-stop, then finalize, then delete the disk. It's a bit verbose.
Can the web users delete a disk that is in this state? That would be my concern that some CLI user started then abandoned the import process, and a UI user wants to clean up this disk and them not being able to.
I don't see why not if the console is taught about the new disk states and the import related endpoints.
Originally posted by @jmpesp in https://github.com/oxidecomputer/omicron/issues/2418#issuecomment-1454202140
We should allow the console user to delete disks that are in importing state (and whatever cleanup is required from that).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the console's disk deletion entry point and the import-related endpoints, including the importing states mentioned in the issue. Determine the cleanup required for an abandoned import and verify that console users can delete disks in each relevant importing state.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- api, backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100