oxidecomputer / oxidecomputer/omicron

implement OAuth refresh tokens

Open
#2,306 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

authn idp security
Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

We do not currently implement OAuth refresh tokens. Clients are supposed to get a refresh token and use that to obtain a new access token before their current access token expires. Refresh tokens are currently not needed because we also haven't implemented #2302. But we're presumably going to need that for MVP, and then I think we're going to want this.

reference: https://github.com/oxidecomputer/omicron/blob/9d1bd5539225b6a225ba3655ceab852c71baa04a/nexus/types/src/external_api/views.rs#L419

(edit: this comment was removed under https://github.com/oxidecomputer/omicron/pull/2417 but the issue remains)

CC @plotnick
See also #2302.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with nexus/types/src/external_api/views.rs around line 419 and read issue #2302, since the issue says refresh tokens depend on that work. Map the existing OAuth access-token flow and define completion as clients receiving refresh tokens and using them to obtain new access tokens before expiration.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
api, authentication
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.