oxidecomputer / oxidecomputer/omicron

remove built-in silo, move built-in users to the test suite

Open
#2,305 7 comments 0 reactions 1 assignee View on GitHub

@davepacheco is already working on this.

Since Aug 15, 2023.

security
Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

The built-in Silo with its built-in users have been useful, but they were always intended as a stepping stone until we had more real facilities. Once we do #2304, I think we'll be able to remove these.

The remaining hard part is probably the test suite. We may want to have it create its own Silo with these same test users. The difference will only be that these are created by the test suite rather than automatically by Nexus. This is kind of a big difference in terms of security, since these test users won't be present in real systems.

Depends on #2304.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.