oxidecomputer / oxidecomputer/omicron
[tests] disk_create saga should add more DiskSource
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
The current tests for the disk_create saga (in nexus/src/app/sagas/disk_create.rs)
only use the DiskSource::Blank enum. We should expand the test coverage to
include the other enums.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in nexus/src/app/sagas/disk_create.rs and inspect the existing disk_create saga tests alongside the DiskSource enum definition. Run the current test for this saga, then expand the cases beyond DiskSource::Blank. Done means the tests cover the other DiskSource variants and pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100