oxidecomputer / oxidecomputer/omicron

[tests][nice-to-have] Resource Helpers would be more useful as builders

Open
#2,114 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

nexus Testing & Analysis
Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

Context: https://github.com/oxidecomputer/omicron/pull/2113/files#r1063578360

The resource helpers might be more useful if they used a "builder pattern", to allow optionally changing features, such as the authentication information across a wide range of NexusRequest objects

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the files and discussion linked from PR 2113, then trace the resource helpers and their NexusRequest usage. Determine how the helpers are currently constructed and where authentication is set. Done means the intended builder behavior is agreed on and tests cover changing authentication across multiple NexusRequest objects.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
api, testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.