oxidecomputer / oxidecomputer/omicron
Tracking issue for saga unwind safety
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
This issue tracks testing that if we fail a particular action in a saga, we can safely unwind (performing undo actions) and leave the system in a "clean" state.
- Instance create: https://github.com/oxidecomputer/omicron/pull/1843
- Instance delete
- Disk create: https://github.com/oxidecomputer/omicron/pull/1835
- Disk Delete
- Snapshot Create: https://github.com/oxidecomputer/omicron/pull/2093
- Snapshot Delete
- Volume Delete
- Volume Remove ROP
- Project Creation: https://github.com/oxidecomputer/omicron/pull/2087
- Project Deletion
- VPC Creation: https://github.com/oxidecomputer/omicron/pull/2086
- VPC Deletion
- Instance Migration
If other sagas are added without unwind safety tests, they should be added to this list.
Related to https://github.com/oxidecomputer/omicron/issues/1799, https://github.com/oxidecomputer/omicron/issues/2094
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the unchecked saga entries in the tracking list and the related issues 1799 and 2094 to understand the expected unwind behavior. Add safety coverage for a selected saga, verifying that a failed action runs its undo actions and leaves the system in a clean state; mark the entry complete once the test passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend, testing-qa
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100