oxidecomputer / oxidecomputer/omicron

Separate installations on the same network can interfere with each other

Open
#1,639 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

Here is a CI failure: https://github.com/oxidecomputer/omicron/runs/7887995648

This failure occurred shortly after we added sock to Buildomat to work alongside buskin for lab jobs. This job ran on sock, and ddmd picked up a prefix during startup:

SledAgent (RSS): Received prefixes from ddmd
    prefixes = {"fe80::8:20ff:fe9e:7b26": [Ipv6Prefix { addr: fd00:1122:3344:1::, mask: 64 }, Ipv6Prefix { addr: fdb0:18c0:4d0d:9fb2::, mask: 64 }, Ipv6Prefix { addr: fd00:1122:3344:101::, mask: 64 }]}

This prefix was advertised by ddmd on buskin, during https://github.com/oxidecomputer/omicron/runs/7887685952:

SledAgent: Sending prefix to ddmd for advertisement
    prefix = Ipv6Prefix { addr: fdb0:18c0:4d0d:9fb2::, mask: 64 }

The result is that the job on sock created a plan for two sled agents, I think, then failed to start sled agent because it was already running on buskin?

There is a timestamp discrepancy in the logs; either sock's time is one hour in the future, or... well, I'm not sure what else it'd be. Some sort of lab network state being cached somewhere?

@jclulow is changing the lab network so that sock and buskin are on two separate VLANs, which seems like the correct configuration for CI, so not labeling this as a test flake. Instead I'd like to know if we want to prevent this kind of thing from happening elsewhere, e.g. someone testing two separate control plane installations at once on their home network without intending for them to talk to each other, or if that's just a bad idea.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked CI failure and the ddmd and SledAgent log excerpts, comparing the sock and buskin runs and their advertised prefixes. Trace where installation identity or network isolation is handled. Done requires a decided behavior for preventing unintended cross-installation communication, with a reproducible test or documented reason why VLAN separation is required.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
distributed-systems, networking
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.