oxidecomputer / oxidecomputer/omicron
calls into Oso can block
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
For background, see this comment. Oso's is_authorized() call can block on locks. We're currently doing this from async code in tokio core threads. Instead, this needs to happen on blocking threads.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked background comment and the authorization paths that call Oso's is_authorized() from async Tokio code. Check Tokio's blocking-code guidance first; done means the potentially lock-blocking Oso call runs on blocking threads rather than Tokio core threads.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100