oxidecomputer / oxidecomputer/omicron
OPTE virtual gateway MAC address should be provided by Nexus
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
OPTE acts as a virtual gateway to guests, and so needs both an IP and MAC address. The IP is always reserved to be the first in the VPC subnet. The MAC address however, is currently hardcoded in the sled agent. The fact that it's hardcoded is OK, but that should be done in Nexus. The value really should be stored in Cockroach, so that it can be consistently controlled and we can avoid duplicates where applicable. Nexus will then need to supply the value to the sled agent, for example during instance provision requests.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the hardcoded MAC address in sled-agent/src/opte/opte.rs at the linked location, then trace how Nexus handles instance provision requests. Inspect the Cockroach persistence path and the request passed to the sled agent. Done means the MAC is stored and controlled by Nexus and supplied during provisioning instead of being hardcoded in the sled agent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- api, backend, databases, networking
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100