oxidecomputer / oxidecomputer/omicron

Fix device auth error handling

Open
#1,286 0 comments 0 reactions 1 assignee View on GitHub

@plotnick is already working on this.

Since Jun 27, 2022.

Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

Most of the device authorization endpoints (external_api/device_auth.rs) should not return Result<_, HttpError>, since in the error case they will not be valid OAuth errors (they'll be dropshot::HttpErrorResponseBody).

Also investigate why (or indeed if) instrumentation doesn't work with Response<Body>.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.