oxidecomputer / oxidecomputer/omicron
sled agent hardware monitor should use sysevent
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
When the sled agent looks at hardware (monitoring for disks, tofino, firmware, etc) it currently uses a five second timer to decide that it should take a snapshot.
This works okay. but it takes several snapshots it doesn't need (e.g, most of them, which eats up some CPU time we'd like to use for other stuff) and introduces a few seconds of delay actually noticing new events when they arrive.
If we instead used:
- A much longer timer (e.g. 60 secs?)
- AND sysevent,
We could wake up immediately when devices are added or removed.
(With a cursory glance: This should be possible with the EC_DEV_{add,remove} events)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the sled agent's hardware-monitoring entry point and trace the current five-second snapshot timer. Check how EC_DEV_add and EC_DEV_remove sysevents can wake monitoring, while retaining a much longer periodic timer. Done means device additions and removals are noticed promptly without unnecessary snapshots.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- operating-systems
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100