oxidecomputer / oxidecomputer/omicron

SystemDescription: fault-injection knobs and hardware lifecycle for the FM simulator

Open
#11,212 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

RFD 726 proposes deriving the FM simulator's inventory and in-service-disk inputs from SystemDescription. If we go that direction, we'll need a few additions.

Per-disk setters. None exist today; the only write to a disk's policy is the bulk one in sled_expunge.

  • serial_to_disk_id: disk counterpart of the existing serial_to_sled_id
  • disk_set_zpool_health: collections currently always report ZpoolHealth::Online
  • disk_set_zpool_size
  • disk_set_firmware: the NVMe firmware metadata reported in inventory
  • disk_set_policy: each SledDisk already stores a PhysicalDiskPolicy; there's just no per-disk setter
  • disk_set_inventory_visibility: per-disk analogue of the existing sled_set_inventory_visibility

Caller-supplied serials. Sled serials are hardcoded as serial{N} and a synthetic disk's serial is derived from its zpool's UUID, which no simulator script could predict. Both need to accept caller-chosen values.

Hardware joining and leaving a live system. Disks exist only at sled
creation (via SledBuilder::npools), and sled_remove erases the sled entirely. The simulator needs hardware that is out of the rack (created but not yet inserted, or removed) to stay in the SystemDescription, keeping its serial, settings, and policy while absent from collections.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read RFD 726 and the SystemDescription implementation in nexus/reconfigurator/planning/src/system.rs, especially the referenced sled and disk builders and lifecycle methods. Trace how serials, disk policies, inventory visibility, and collections are represented before deciding how the simulator can retain hardware outside the rack. Done means the requested per-disk controls, caller-supplied serials, and join/leave lifecycle are supported while preserving hardware state.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend, backend-api-design
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.