oxidecomputer / oxidecomputer/omicron
If sled-agent can't get the reservoir it wants, it should tell someone
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
Until recently, if sled-agent could not allocate the reservoir it wanted it would log an error but do nothing more.
Recent changes by @papertigers added error checking to sled-agent and let Nexus know on failure how much of the requested size we were able to add to the reservoir.
However, we should also notify or generate an error report, as we believe this is not expected and should be reported.
this is part of work around https://github.com/oxidecomputer/omicron/issues/11130
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with sled-agent's reservoir allocation and the recent error-checking changes described in the issue, then review the related work in issue #11130. Done means an allocation failure both reports how much was added to Nexus and produces the requested notification or error report.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Needs clarification
- Newbie friendliness
- 45/100