oxidecomputer / oxidecomputer/omicron

Port setting view/create are structurally asymmetric making updates arduous

Open
#11,160 0 comments 0 reactions 1 assignee View on GitHub

@internet-diglett is already working on this.

Since Aug 25, 2026.

api networking
Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 12h
Merged PRs (30d)
96

Description

The input to networking_switch_port_settings_create

https://github.com/oxidecomputer/omicron/blob/9df8ac02864f706c44b17831b2b55dda42178b1b/nexus/external-api/src/lib.rs#L5279-L5292

https://github.com/oxidecomputer/omicron/blob/9df8ac02864f706c44b17831b2b55dda42178b1b/nexus/types/versions/src/stronger_bgp_unnumbered_types/networking.rs#L264-L295

is structurally different from what we get from networking_switch_port_settings_view

https://github.com/oxidecomputer/omicron/blob/9df8ac02864f706c44b17831b2b55dda42178b1b/nexus/external-api/src/lib.rs#L5449-L5459

https://github.com/oxidecomputer/omicron/blob/9df8ac02864f706c44b17831b2b55dda42178b1b/nexus/types/versions/src/remove_duplicated_networking_types/networking.rs#L55-L83

What this means, is that when a user is trying to update switch port settings via the CLI, they need to fetch the settings in one format, do a mind meld with the OpenAPI specification or the underlying Nexus Rust data structures to figure out how to translate into the create format, implement that translation in JSON and then ship the updated json in the update request.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.