oxidecomputer / oxidecomputer/omicron
sled-agent only validates U.2 LBA format on unlabeled disks and wrong block size on an adopted disk is not detected or reported
Open
Nobody has claimed this yet.
bug
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
sled-agent will format a U.2 to the desired 4k LBA data size when the disk arrives with no GPT label. On a disk that already has a label, the LBA format is not read or reported.
It would be good to always read and validate the LBA format on U.2 drives during adoption.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with sled-hardware/src/illumos/partitions.rs at the linked lines 214 and 227, then trace sled-agent's U.2 disk-adoption path. Compare labeled and unlabeled disks and verify that adoption always reads, validates, and reports the LBA format; done means a wrong block size on an adopted disk is detected and reported.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 62/100