oxidecomputer / oxidecomputer/omicron
`IncompleteExternalIp` constructors could accept typed UUIDs
Open
Beginner friendly
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 572
- Forks
- 97
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 96
Description
See here:
We're accepting a lot of bare UUIDs in these methods, and #10845 adds another one. We probably want to accept typed UUIDs here to avoid mixing things up.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at nexus/db-model/src/external_ip.rs lines 261-265 and inspect the IncompleteExternalIp constructors and the typed UUID definitions or usages they should follow. Update the constructor inputs to use typed UUIDs, account for the additional case from issue #10845, and verify affected callers still build without mixing UUID types.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- database
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 72/100